On Fri, Apr 02, 2021, Paolo Bonzini wrote: > On 02/04/21 01:05, Sean Christopherson wrote: > > > > > > +struct kvm_queued_exception { > > > + bool valid; > > > + u8 nr; > > > > If we're refactoring all this code anyways, maybe change "nr" to something a > > bit more descriptive? E.g. vector. > > "nr" is part of the userspace structure, so consistency is an advantage too. Foiled at every turn. Keeping "nr" probably does make sense.