On Sun, Oct 11, 2009 at 08:53:05PM -0300, Lucas Meneghel Rodrigues wrote: > On Sat, 2009-10-10 at 16:48 +0800, Yolkfull Chow wrote: > > On Sat, Oct 10, 2009 at 04:24:45PM +0800, Yolkfull Chow wrote: > > > On Mon, Oct 05, 2009 at 04:03:22PM -0300, Lucas Meneghel Rodrigues wrote: > > > > Hi Yolkfull! I've checked your patch, but it turns out that the comma > > > > is valid syntax for the logging module. By any chance you actually had > > > > an error with it? > > > > > > Hi Lucas, > > > I just checked, yes it's valid syntax for this module. Before this I met > > > a traceback during running autotest and it indicated this line > > > around,thus I doubt about this by mistake. Sorry for confusing. ;-) > > > > > > But I found for the variables in logging.debug(),sometimes it use comma > > > to format while sometimes '%' which will drop code readability. > > > > Another reason is if someone who still using kvm_log want to backport > > codes from this tree, not only need he replace all 'logging' with > > 'kvm_log' but also need change these comma syntax. ;-) > > Yes, we prefer using comma on logging statements allways, but sometimes > we make mistakes and use the standard string format with %. > > When porting code, try to keep in mind that and try to use allways the > comma, but don't worry too much about it... just general guidelines :) Ok, that could be the style. Thanks very much for remind. :) Cheers, > > Lucas > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
