RE: [PATCH 09/10] vfio/pci: Replace uses of vfio_device_data() with container_of

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jason,

> From: Jason Gunthorpe <jgg@xxxxxxxxxx>
> Sent: Wednesday, March 10, 2021 5:39 AM
> 
> This tidies a few confused places that think they can have a refcount on
> the vfio_device but the device_data could be NULL, that isn't possible by
> design.

I think the purpose of this patch is to use container_of in vfio_pci driver
since patch 0008 has already let the callbacks of vfio_device_ops to pass in
struct vfio_device, which can be used to get the vfio_pci_device easily with
container_of. Just not quite get relationship between the above commit message.
and the actual purpose. But I'm not a native speaker, so this is not a strong
comment. Just FYI.

Regards,
Yi Liu





[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux