On Tue, Feb 02, 2021, Paolo Bonzini wrote: > On 02/02/21 19:00, Dave Hansen wrote: > > > /* "" Basic SGX */ > > > /* "" SGX Enclave Dynamic Memory Mgmt */ > > Do you actually want to suppress these from /proc/cpuinfo with the ""? > > > > sgx1 yes. However sgx2 can be useful to have there, I guess. Agreed, /proc/cpuinfo's sgx1 will always be in lockstep with sgx, so it won't be useful for dealing with the fallout of hardware disabling SGX due to software disabling a machine check bank via WRMSR(MCi_CTL). I can't think of any other use case for checking /proc/cpuinfo's sgx1.