Re: [RFC PATCH v3 01/27] x86/cpufeatures: Add SGX1 and SGX2 sub-features

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [RFC PATCH v3 01/27] x86/cpufeatures: Add SGX1 and SGX2 sub-features
From: Paolo Bonzini <pbonzini@xxxxxxxxxx>
Date: Tue, 2 Feb 2021 18:56:33 +0100
Cc: Dave Hansen <dave.hansen@xxxxxxxxx>, linux-sgx@xxxxxxxxxxxxxxx, kvm@xxxxxxxxxxxxxxx, x86@xxxxxxxxxx, seanjc@xxxxxxxxxx, luto@xxxxxxxxxx, haitao.huang@xxxxxxxxx, bp@xxxxxxxxx, tglx@xxxxxxxxxxxxx, mingo@xxxxxxxxxx, hpa@xxxxxxxxx
In-reply-to: <20210201130151.4bfb5258885ca0f0905858c6@intel.com>
References: <cover.1611634586.git.kai.huang@intel.com> <aefe8025b615f75eae3ff891f08191bf730b3c99.1611634586.git.kai.huang@intel.com> <ca0fa265-0886-2a37-e686-882346fe2a6f@intel.com> <3a82563d5a25b52f0b5f01560d70c50a2323f7e5.camel@intel.com> <YBVdNl+pTBBm6igw@kernel.org> <20210201130151.4bfb5258885ca0f0905858c6@intel.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0

On 01/02/21 01:01, Kai Huang wrote:

I think we can remove comment for SGX1, since it is basically SGX.

For SGX2, how about below?

/* SGX Enclave Dynamic Memory Management */

(EDMM)

Does EDMM obvious to everyone, instead of explicitly saying Enclave Dynamic
Memory Management?

Also do you think we need a comment for SGX1 bit? I can add /* Basic SGX */,
but I am not sure whether it is required.


Yes, please use

/* "" Basic SGX */
/* "" SGX Enclave Dynamic Memory Mgmt */

Paolo

Follow-Ups:
- Re: [RFC PATCH v3 01/27] x86/cpufeatures: Add SGX1 and SGX2 sub-features
  - From: Dave Hansen

References:
- [RFC PATCH v3 00/27] KVM SGX virtualization support
  - From: Kai Huang
- [RFC PATCH v3 01/27] x86/cpufeatures: Add SGX1 and SGX2 sub-features
  - From: Kai Huang
- Re: [RFC PATCH v3 01/27] x86/cpufeatures: Add SGX1 and SGX2 sub-features
  - From: Dave Hansen
- Re: [RFC PATCH v3 01/27] x86/cpufeatures: Add SGX1 and SGX2 sub-features
  - From: Kai Huang
- Re: [RFC PATCH v3 01/27] x86/cpufeatures: Add SGX1 and SGX2 sub-features
  - From: Jarkko Sakkinen
- Re: [RFC PATCH v3 01/27] x86/cpufeatures: Add SGX1 and SGX2 sub-features
  - From: Kai Huang

Prev by Date: Re: [PATCH 8/9] vfio/pci: use x86 naming instead of igd
Next by Date: Re: [RFC PATCH v3 01/27] x86/cpufeatures: Add SGX1 and SGX2 sub-features
Previous by thread: Re: [RFC PATCH v3 01/27] x86/cpufeatures: Add SGX1 and SGX2 sub-features
Next by thread: Re: [RFC PATCH v3 01/27] x86/cpufeatures: Add SGX1 and SGX2 sub-features
Index(es):
- Date
- Thread

[Index of Archives] [KVM ARM] [KVM ia64] [KVM ppc] [Virtualization Tools] [Spice Development] [Libvirt] [Libvirt Users] [Linux USB Devel] [Linux Audio Users] [Yosemite Questions] [Linux Kernel] [Linux SCSI] [XFree86]