Re: [RFC PATCH v2 12/26] x86/sgx: Add helper to update SGX_LEPUBKEYHASHn MSRs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [RFC PATCH v2 12/26] x86/sgx: Add helper to update SGX_LEPUBKEYHASHn MSRs
From: Dave Hansen <dave.hansen@xxxxxxxxx>
Date: Wed, 20 Jan 2021 17:15:35 -0800
Cc: Jarkko Sakkinen <jarkko@xxxxxxxxxx>, linux-sgx@xxxxxxxxxxxxxxx, kvm@xxxxxxxxxxxxxxx, x86@xxxxxxxxxx, seanjc@xxxxxxxxxx, luto@xxxxxxxxxx, haitao.huang@xxxxxxxxx, pbonzini@xxxxxxxxxx, bp@xxxxxxxxx, tglx@xxxxxxxxxxxxx, mingo@xxxxxxxxxx, hpa@xxxxxxxxx
In-reply-to: <20210121140638.b9bac5af44fc0f33996a2853@intel.com>
References: <cover.1610935432.git.kai.huang@intel.com> <5116fdc732e8e14b3378c44e3b461a43f330ed0c.1610935432.git.kai.huang@intel.com> <YAgcIhkmw0lllD3G@kernel.org> <8613b3f1-c4f6-3e5d-4406-9476727666a7@intel.com> <20210121123625.c45deeccc690138f2417bd41@intel.com> <982ddc27-27ec-2d03-54a4-1c0b07e8a3c9@intel.com> <20210121140638.b9bac5af44fc0f33996a2853@intel.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0

On 1/20/21 5:06 PM, Kai Huang wrote:
> 
> /*
>  * Update the SGX_LEPUBKEYHASH MSRs to the values specified by caller.
>  *
>  * EINITTOKEN is not used in enclave initialization, which requires
>  * hash of enclave's signer must match values in SGX_LEPUBKEYHASH MSRs
>  * to make EINIT be successful.
>  */

I'm grumpy, but I hate it.

I'll stop the bike shedding for now, though.

Follow-Ups:
- Re: [RFC PATCH v2 12/26] x86/sgx: Add helper to update SGX_LEPUBKEYHASHn MSRs
  - From: Kai Huang

References:
- [RFC PATCH v2 00/26] KVM SGX virtualization support
  - From: Kai Huang
- [RFC PATCH v2 12/26] x86/sgx: Add helper to update SGX_LEPUBKEYHASHn MSRs
  - From: Kai Huang
- Re: [RFC PATCH v2 12/26] x86/sgx: Add helper to update SGX_LEPUBKEYHASHn MSRs
  - From: Jarkko Sakkinen
- Re: [RFC PATCH v2 12/26] x86/sgx: Add helper to update SGX_LEPUBKEYHASHn MSRs
  - From: Dave Hansen
- Re: [RFC PATCH v2 12/26] x86/sgx: Add helper to update SGX_LEPUBKEYHASHn MSRs
  - From: Kai Huang
- Re: [RFC PATCH v2 12/26] x86/sgx: Add helper to update SGX_LEPUBKEYHASHn MSRs
  - From: Dave Hansen
- Re: [RFC PATCH v2 12/26] x86/sgx: Add helper to update SGX_LEPUBKEYHASHn MSRs
  - From: Kai Huang

Prev by Date: Re: [RFC PATCH v2 12/26] x86/sgx: Add helper to update SGX_LEPUBKEYHASHn MSRs
Next by Date: Re: [RFC PATCH v2 12/26] x86/sgx: Add helper to update SGX_LEPUBKEYHASHn MSRs
Previous by thread: Re: [RFC PATCH v2 12/26] x86/sgx: Add helper to update SGX_LEPUBKEYHASHn MSRs
Next by thread: Re: [RFC PATCH v2 12/26] x86/sgx: Add helper to update SGX_LEPUBKEYHASHn MSRs
Index(es):
- Date
- Thread

[Index of Archives] [KVM ARM] [KVM ia64] [KVM ppc] [Virtualization Tools] [Spice Development] [Libvirt] [Libvirt Users] [Linux USB Devel] [Linux Audio Users] [Yosemite Questions] [Linux Kernel] [Linux SCSI] [XFree86]