On 1/20/21 4:03 AM, Jarkko Sakkinen wrote: >> +void sgx_update_lepubkeyhash(u64 *lepubkeyhash) >> +{ >> + int i; >> + >> + for (i = 0; i < 4; i++) >> + wrmsrl(MSR_IA32_SGXLEPUBKEYHASH0 + i, lepubkeyhash[i]); >> +} > Missing kdoc. I dunno... kdoc is nice, but I'm not sure its verbosity is useful here, even if this function is called from more than one .c file. I'd be happy with a single-line comment, personally.