On 12/15/20 3:07 PM, Richard Henderson wrote: > On 12/14/20 12:37 PM, Philippe Mathieu-Daudé wrote: >> The rest of helper.c is TLB related. Extract the non TLB >> specific functions to a new file, so we can rename helper.c >> as tlb_helper.c in the next commit. >> >> Signed-off-by: Philippe Mathieu-Daudé <f4bug@xxxxxxxxx> >> --- >> target/mips/internal.h | 2 + >> target/mips/cpu.c | 215 +++++++++++++++++++++++++++++++++++++++-- >> target/mips/helper.c | 201 -------------------------------------- >> 3 files changed, 211 insertions(+), 207 deletions(-) > > Subject and comment need updating for cpu.c. Otherwise, > > Reviewed-by: Richard Henderson <richard.henderson@xxxxxxxxxx> Oops, fixed as: target/mips: Move common helpers from helper.c to cpu.c The rest of helper.c is TLB related. Extract the non TLB specific functions to cpu.c, so we can rename helper.c as tlb_helper.c in the next commit. Thanks! Phil.