Hi, This series contains the patches previously sent in "Boring code reordering" [1] and "Add translate.h and fpu_translate.h headers" [2]. I removed the patches merged and addressed Richard review comments. Missing review: 1 3-5 9-11 14 15 Available as: https://gitlab.com/philmd/qemu/-/commits/refactor_translate_h Regards, Phil. Based-on: https://gitlab.com/philmd/qemu.git tags/mips-next Supersedes: <20201206233949.3783184-1-f4bug@xxxxxxxxx> Supersedes: <20201207235539.4070364-1-f4bug@xxxxxxxxx> [1] https://www.mail-archive.com/qemu-devel@xxxxxxxxxx/msg764551.html [2] https://www.mail-archive.com/qemu-devel@xxxxxxxxxx/msg764828.html Philippe Mathieu-Daudé (16): target/mips: Inline cpu_state_reset() in mips_cpu_reset() target/mips: Extract FPU helpers to 'fpu_helper.h' target/mips: Add !CONFIG_USER_ONLY comment after #endif target/mips: Remove consecutive CONFIG_USER_ONLY ifdefs target/mips: Extract common helpers from helper.c to common_helper.c target/mips: Rename helper.c as tlb_helper.c target/mips: Fix code style for checkpatch.pl target/mips: Move mmu_init() functions to tlb_helper.c target/mips: Rename translate_init.c as cpu-defs.c target/mips: Replace gen_exception_err(err=0) by gen_exception_end() target/mips: Replace gen_exception_end(EXCP_RI) by gen_rsvd_instruction target/mips/translate: Extract DisasContext structure target/mips/translate: Add declarations for generic code target/mips: Declare generic FPU functions in 'translate.h' target/mips: Extract FPU specific definitions to translate.h target/mips: Only build TCG code when CONFIG_TCG is set target/mips/fpu_helper.h | 59 ++ target/mips/internal.h | 52 +- target/mips/translate.h | 166 ++++ linux-user/mips/cpu_loop.c | 1 + target/mips/cpu.c | 243 ++++- target/mips/fpu_helper.c | 1 + target/mips/gdbstub.c | 1 + target/mips/kvm.c | 1 + target/mips/machine.c | 1 + target/mips/msa_helper.c | 1 + target/mips/op_helper.c | 2 +- target/mips/{helper.c => tlb_helper.c} | 260 ++--- target/mips/translate.c | 897 ++++++++---------- .../{translate_init.c.inc => cpu-defs.c.inc} | 50 +- target/mips/meson.build | 10 +- 15 files changed, 903 insertions(+), 842 deletions(-) create mode 100644 target/mips/fpu_helper.h create mode 100644 target/mips/translate.h rename target/mips/{helper.c => tlb_helper.c} (87%) rename target/mips/{translate_init.c.inc => cpu-defs.c.inc} (96%) -- 2.26.2