On 19/10/20 19:07, Ben Gardon wrote: > On Fri, Oct 16, 2020 at 9:18 AM Paolo Bonzini <pbonzini@xxxxxxxxxx> wrote: >> >> On 14/10/20 20:26, Ben Gardon wrote: >>> >>> + if (kvm->arch.tdp_mmu_enabled) >>> + kvm_tdp_mmu_clear_dirty_pt_masked(kvm, slot, >>> + slot->base_gfn + gfn_offset, mask, true); >> >> This was "false" in v1, I need --verbose for this change. :) > > I don't think this changed from v1. Note that there are two callers in > mmu.c - kvm_mmu_write_protect_pt_masked and > kvm_mmu_clear_dirty_pt_masked. One calls with wrprot = true and the > other with wrprot = false. Ah, I messed up fixing the conflicts. Paolo