On 14/10/20 20:26, Ben Gardon wrote: > > + if (kvm->arch.tdp_mmu_enabled) > + kvm_tdp_mmu_clear_dirty_pt_masked(kvm, slot, > + slot->base_gfn + gfn_offset, mask, true); This was "false" in v1, I need --verbose for this change. :) > while (mask) { > rmap_head = __gfn_to_rmap(slot->base_gfn + gfn_offset + __ffs(mask), > + spte_set = wrprot_gfn_range(kvm, root, slot->base_gfn, > + slot->base_gfn + slot->npages, min_level) || > + spte_set; A few remaining instances of ||. Paolo