On Fri, Aug 28, 2020 at 02:12:26PM +0200, Joerg Roedel wrote: > Hi Arvind, > > On Thu, Aug 27, 2020 at 11:26:57AM -0400, Arvind Sankar wrote: > > On Mon, Aug 24, 2020 at 10:54:08AM +0200, Joerg Roedel wrote: > > > + pushq %rsi > > > + call load_stage1_idt > > > + popq %rsi > > > + > > > > Do we need the functions later in the series or could this just use lidt > > directly? > > The function also sets up the actual IDT entries in the table before > doing the lidt, so this needs to be a call to a C function. Setting up > IDT entries in assembly does not result in readable code. > Ah ok, I missed that in the later patches. Thanks.