On 31/07/2020 09.45, Andrew Jones wrote: > On Fri, Jul 31, 2020 at 09:17:53AM +0200, Paolo Bonzini wrote: >> On 31/07/20 09:13, Thomas Huth wrote: >>> the bash version that Apple ships is incredibly old (version 3). >> >> Yes, due to GPLv3. :( I think either we rewrite the whole thing in >> Python (except for the "shar"-like code in mkstandalone.sh) > > I once suggested Python (or anything less awkward than Bash) be used > for our harness, but ARM people told me that they like Bash because > then they can install the unit tests on minimal images that they > use on the ARM models. There may other "embedded" cases for kvm-unit-tests > in the future too, if we were to introduce bare-metal targets, etc., > so I think the minimal language (Bash) requirement makes sense to > maintain (not to mention we already wrote it...) > >> or we keep >> bash 4 as the minimum supported version. > > Is 4.2 OK? That would allow Thomas' CI to get the coverage we need > by using CentOS, without having to install a specific Bash. Bash v4.2 has been released in February 2011, so that's more than 9 years already. I don't think that we should support any older version than this. Thomas
