On 31/07/2020 08.32, Andrew Jones wrote: > On Fri, Jul 31, 2020 at 08:09:09AM +0200, Thomas Huth wrote: >> The "|&" only works with newer versions of the bash. For compatibility >> with older versions, we should use "2>&1 |" instead. > > Hi Thomas, > > Which bash version are you targeting with this change? I played a little bit with the macOS containers on Travis, to see whether we could easily get some CI coverage for that after commit 7edd698ed003e introduced hvf support... and the bash version that Apple ships is incredibly old (version 3). But it seems to break in some other spots, too, so I think it likely makes more sense to install a newer version of the bash with homebrew there... > I think it's time we pick a bash version that we want to support > (thoroughly test all the scripts with it) and then document it. Makes sense. Version 3 is definitely too old ;-) > As > part of the CI we should test with both that version and with the > latest released version I think we should already have a good test coverage for newer versions by using the latest version of Fedora in the CI. For old versions, we could add a CI job based on CentOS 7 maybe? That would be Bash v4.2 if I got that right... Thomas
