On 10/07/20 23:21, Nadav Amit wrote: >> On Jul 10, 2020, at 1:45 PM, Paolo Bonzini <pbonzini@xxxxxxxxxx> wrote: >> >> On 10/07/20 20:33, Nadav Amit wrote: >>> DR4/DR5 can only be written when CR4.DE is clear, and otherwise trigger >>> a #GP exception. The BIOS might not clear CR4.DE so update the tests not >>> to make this assumption. >>> >>> >> >> I think we should just start with a clean slate and clear CR4 in cstart*.S: > > Your change seems fine. If you can push it (with the rest of the recent svm > changes), I would prefer to run it, before I need to return my AMD machine. > Done now. Paolo
