On Thu, Jul 09, 2020 at 08:24:03PM +0200, Paolo Bonzini wrote: > On 09/07/20 20:22, Peter Xu wrote: > >>> So I think Peter's patch is fine, but (possibly on top as a third patch) > >>> __must_check should be added to MSR getters and setters. Also one > >>> possibility is to return -EINVAL for invalid MSRs. > > Yeah I can add another patch for that. Also if to repost, I tend to also > > introduce KVM_MSR_RET_[OK|ERROR] too, which seems to be cleaner when we had > > KVM_MSR_RET_INVALID. > > You can use either that or 0/1/-EINVAL. I would be fine with that to > keep the patch small. Yeah -EINVAL looks good. Then, do you want me to s/1/-EFAULT/ altogether? -- Peter Xu
