On 04/06/2020 07.56, David Gibson wrote: > On Mon, Jun 01, 2020 at 08:54:42PM -0700, Richard Henderson wrote: >> On 5/20/20 8:43 PM, David Gibson wrote: >>> +++ b/include/hw/boards.h >>> @@ -12,6 +12,8 @@ >>> #include "qom/object.h" >>> #include "hw/core/cpu.h" >>> >>> +typedef struct GuestMemoryProtection GuestMemoryProtection; >>> + >> >> I think this needs to be in include/qemu/typedefs.h, >> and the other typedef in patch 10 needs to be moved there. >> >> IIRC, clang warns about duplicate typedefs. > > Not, apparently, with the clang version I have, but I've made the > change anyway. FWIW, we got rid of that duplicated typedef problem in commit e6e90feedb706b1b92, no need to worry about that anymore. Thomas
