On 5/20/20 8:43 PM, David Gibson wrote: > +++ b/include/hw/boards.h > @@ -12,6 +12,8 @@ > #include "qom/object.h" > #include "hw/core/cpu.h" > > +typedef struct GuestMemoryProtection GuestMemoryProtection; > + I think this needs to be in include/qemu/typedefs.h, and the other typedef in patch 10 needs to be moved there. IIRC, clang warns about duplicate typedefs. r~