пон, 25. мај 2020. у 03:23 Huacai Chen <chenhc@xxxxxxxxxx> је написао/ла: > > Hi, Aleksandar, > > On Mon, May 25, 2020 at 8:26 AM Aleksandar Markovic > <aleksandar.qemu.devel@xxxxxxxxx> wrote: > > > > > V7 -> V8: > > > 1, Rebase to be applied on kvm tree, i.e., the linux-next branch of > > > https://git.kernel.org/pub/scm/virt/kvm/kvm.git/. Building KVM/MIPS > > > need commit 3fbfb4585bfd4ff34e ("mips: define pud_index() regardless > > > of page table folding"), which has already been in mips tree but not > > > in kvm tree. > > > > > > > Huacai, > > > > I do support and salute the series (as I always did), as I see it as a > > giant step forward for KVM for MIPS. > > > > However, in general, I think any series should not depend on "pick > > that patch from another tree", and should be a stand-alone unit that > > yields to successful build and desired functionality. If there is a > > dependency like you described, the patch in question, in my opinion, > > should be integrated into the series in question. Git is even smart > > enough that it recognizes the same patch has been applied before, so > > integration of another tree would not be exposed to problems. > > > > From the point of view of synchronizing with QEMU part, and the timing > > issues wrt kernel and QEMU releases, I want to stress that it is > > better that this series is integrated sooner rather than later. In > > other words, I think that potential Paolo's KVM pull request should > > happen before Thomas' mips-next pull request (Paolo could include > > "mips: define pud_index() regardless of page table folding", and > > Thomas could simply omit it). > > > > But, that said, I don't feel I should impose my opinion to others > > here. Take my statements just as advises. I defer the decision on how > > to proceed with the integration of this series entirely to Paolo and > > Thomas. > I think I lack some experience of cross-subsystem development, so in > V8 I only adjust the context of my own patches to let the series be > applied on kvm tree, but didn't consider patches already in other > trees (Moreover, that patch is not mine). So, should I send a V9 that > take commit 3fbfb4585bfd4ff3 together? > No, I think we should wait for Paolo's feedback. > Thanks, > Huacai > > > > Yours, > > Aleksandar
