Hi Richard, > -----Original Message----- > From: Richard Cochran <richardcochran@xxxxxxxxx> > Sent: Monday, May 25, 2020 2:16 PM > To: Jianyong Wu <Jianyong.Wu@xxxxxxx> > Cc: maz@xxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; yangbo.lu@xxxxxxx; > john.stultz@xxxxxxxxxx; tglx@xxxxxxxxxxxxx; pbonzini@xxxxxxxxxx; > sean.j.christopherson@xxxxxxxxx; Mark Rutland <Mark.Rutland@xxxxxxx>; > will@xxxxxxxxxx; Suzuki Poulose <Suzuki.Poulose@xxxxxxx>; Steven Price > <Steven.Price@xxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx; linux-arm- > kernel@xxxxxxxxxxxxxxxxxxx; kvmarm@xxxxxxxxxxxxxxxxxxxxx; > kvm@xxxxxxxxxxxxxxx; Steve Capper <Steve.Capper@xxxxxxx>; Kaly Xin > <Kaly.Xin@xxxxxxx>; Justin He <Justin.He@xxxxxxx>; Wei Chen > <Wei.Chen@xxxxxxx>; nd <nd@xxxxxxx> > Subject: Re: [RFC PATCH v12 10/11] arm64: add mechanism to let user choose > which counter to return > > On Mon, May 25, 2020 at 04:50:28AM +0000, Jianyong Wu wrote: > > How about adding an extra argument in struct ptp_clock_info to serve as a > flag, then we can control this flag using IOCTL to determine the counter type. > > no, No, NO! > Ok, > > > From your description, this "flag" really should be a module parameter. > > Maybe use flag as a module parameter is a better way. > > Yes. > It's fine for me, if @maz@xxxxxxxxxx is not against with it. Thanks Jianyong > Thanks, > Richard
