On 22/04/2020 00:45, Paolo Bonzini wrote:
On 21/04/20 20:47, Randy Dunlap wrote:
+
+/**
+ * The command is used to trigger enclave start after the enclave resources,
+ * such as memory and CPU, have been set.
+ *
+ * The enclave start metadata is an in / out data structure. It includes
+ * provided info by the caller - enclave cid and flags - and returns the
+ * slot uid and the cid (if input cid is 0).
+ */
+#define NE_ENCLAVE_START _IOWR('B', 0x1, struct enclave_start_metadata)
Please document ioctl major ('B' in this case) and range used in
Documentation/userspace-api/ioctl/ioctl-number.rst.
Since it's really just a couple ioctls, I can "donate" part of the KVM
space, for example major 0xAE minor 0x20-0x3f.
Randy, thanks for the ioctl doc refs.
I can update the ioctl-number doc to add an entry for the the Nitro
Enclaves uapi with 0xAE and 0x20-0x3f range + update the KVM entry to
have 0xAE 0x00-0x1f and 0x40-0xff.
Will then use 0xAE and 0x20 for NE_ENCLAVE_START.
Paolo, let me know if we should do this ioctl number update other way.
And thanks for the proposal. :)
Thanks,
Andra
Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in Romania. Registration number J22/2621/2005.
