On Thu, Mar 05, 2020 at 05:42:59PM +0100, Paolo Bonzini wrote: > On 05/03/20 02:34, Sean Christopherson wrote: > > > > In theory, everything up to the refactoring is non-controversial, i.e. we > > can bikeshed the refactoring without delaying the bug fixes. > > Even the refactoring itself is much less controversial. I queued > everything, there's always time to unqueue. Looks like the build-time assertions don't play nice with older versions of gcc :-( config: x86_64-randconfig-s2-20200305 (attached as .config) compiler: gcc-4.9 (Debian 4.9.2-10+deb8u1) 4.9.2 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp@xxxxxxxxx> All error/warnings (new ones prefixed by >>): In file included from include/linux/export.h:43:0, from include/linux/linkage.h:7, from include/linux/preempt.h:10, from include/linux/hardirq.h:5, from include/linux/kvm_host.h:7, from arch/x86/kvm/emulate.c:21: arch/x86/kvm/emulate.c: In function 'em_cpuid': >> include/linux/compiler.h:350:38: error: call to '__compiletime_assert_3957' declared with attribute error: BUILD_BUG_ON failed: X86EMUL_CPUID_VENDOR_AuthenticAMD_ebx != *(u32 *)"Auth" || X86EMUL_CPUID_VENDOR_AuthenticAMD_edx != *(u32 *)"enti" || X86EMUL_CPUID_VENDOR_AuthenticAMD_ecx != *(u32 *)"cAMD" _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__)