On Fri, Feb 28, 2020 at 08:03:33AM +0100, Paolo Bonzini wrote: > On 28/02/20 01:36, Sean Christopherson wrote: > > Regarding NRIPS, the original commit added the "Support next_rip if host > > supports it" comment, but I can't tell is "host supports" means "supported > > in hardware" or "supported by KVM". In other words, should I make the cap > > dependent "nrips" or leave it as is? > > > > The "nrips" parameter came later. For VMX we generally remove guest > capabilities if the corresponding parameter is on, so it's a good idea > to do the same for SVM. Huh. I swear I looked at the code from the original commit and saw nrips there, but it was clearly added in 2019 via commit d647eb63e671 ("KVM: svm: add nrips module parameter").