On Thu, Feb 27, 2020 at 04:35:20PM +0800, Xiaoyao Li wrote: > On 2/27/2020 7:59 AM, Sean Christopherson wrote: > >Ah, good point. But, that's just another bug in my psuedo patch :-) > >It's literally one call site that needs to be updated. E.g. > > > > if (is_guest_mode(vcpu) && nested_vmx_exit_reflected(vcpu, exit_reason)) > > return nested_vmx_reflect_vmexit(vcpu, full_exit_reason); > > > > shouldn't we also pass full_exit_reason to nested_vmx_exit_reflected()? Yep, see the patch I sent. Alternatively, and perhaps a better approach once we have the union, would be to not pass exit_reason at all and instead have nested_vmx_exit_reflected() grab it directly from vmx->... > > >Everywhere else KVM calls nested_vmx_reflect_vmexit() is (currently) done > > I guess you wanted to say nested_vmx_vmexit() not > nested_vmx_reflect_vmexit() here. Ya. > >with a hardcoded value (except handle_vmfunc(), but I actually want to > >change that one). > > >
