On Tue, Feb 25, 2020 at 04:18:12PM +0100, Paolo Bonzini wrote: > On 01/02/20 19:52, Sean Christopherson wrote: > > +#ifdef CONFIG_KVM_CPUID_AUDIT > > + /* Entry needs to be fully populated when auditing is enabled. */ > > + entry.function = cpuid.function; > > + entry.index = cpuid.index; > > +#endif > > This shows that the audit case is prone to bitrot, which is good reason > to enable it by default. I have no argument against that, especially since I missed this case during development and only caught it when running on a different system that I had happened to configure with CONFIG_KVM_CPUID_AUDIT=y. :-)
