Re: [PATCH v4 06/20] irqchip/gic-v4.1: Add initial SGI configuration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Marc,

On 2020/2/18 17:46, Marc Zyngier wrote:
Hi Zenghui,

On 2020-02-18 07:25, Zenghui Yu wrote:
Hi Marc,

[...]

    static void its_sgi_irq_domain_deactivate(struct irq_domain *domain,
                        struct irq_data *d)
  {
-    /* Nothing to do */
+    struct its_vpe *vpe = irq_data_get_irq_chip_data(d);
+
+    vpe->sgi_config[d->hwirq].enabled = false;
+    its_configure_sgi(d, true);

The spec says, when C==1, VSGI clears the pending state of the vSGI,
leaving the configuration unchanged.  So should we first clear the
pending state and then disable vSGI (let E==0)?

Right you are again. We need two commands, not just one (the pseudocode is
pretty explicit).

With that change,

Reviewed-by: Zenghui Yu <yuzenghui@xxxxxxxxxx>


Thanks




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux