Re: [PATCH] kvm: x86: Print "disabled by bios" only once per host

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



[..]

On 19/02/2020 17:18, Sean Christopherson wrote:
All of that being said, what about converting all of the error messages to
pr_err_ratelimited()?  That would take the edge off this particular problem,
wouldn't create incosistencies between error messages, and won't completely
squash error messages in corner case scenarios on misconfigured systems.

Thanks Sean for your very detailed answer.

I've been testing the ratelimited which is far better but still prints 12 messages.

I saw the ratelimit is on about 5 sec, I wonder if we can explicit a longer one for this one.

I searched around this but it doesn't seems that hacking the delay is a common usage.

Do you have any insights/ideas around that ?


Switching to ratelimit could be done by replacing the actual call or add a macro similar to  kvm_pr_unimpl() so it can be reused easily.

I can offer the patches for that.


Erwan,





[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux