On 17/02/20 18:02, Vitaly Kuznetsov wrote:
>
> Also, apic_lvt_enabled() is only used once with APIC_LVTT as the second
> argument so I'd suggest we also do:
>
> diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c
> index afcd30d44cbb..d85463ff4a6f 100644
> --- a/arch/x86/kvm/lapic.c
> +++ b/arch/x86/kvm/lapic.c
> @@ -289,14 +289,14 @@ static inline void kvm_apic_set_x2apic_id(struct kvm_lapic *apic, u32 id)
> recalculate_apic_map(apic->vcpu->kvm);
> }
>
> -static inline int apic_lvt_enabled(struct kvm_lapic *apic, int lvt_type)
> +static inline int apic_lvtt_enabled(struct kvm_lapic *apic)
> {
> - return !(kvm_lapic_get_reg(apic, lvt_type) & APIC_LVT_MASKED);
> + return !(kvm_lapic_get_reg(apic, APIC_LVTT) & APIC_LVT_MASKED);
> }
>
> -static inline int apic_lvt_vector(struct kvm_lapic *apic, int lvt_type)
> +static inline int apic_lvtt_vector(struct kvm_lapic *apic)
> {
> - return kvm_lapic_get_reg(apic, lvt_type) & APIC_VECTOR_MASK;
> + return kvm_lapic_get_reg(apic, APIC_LVTT) & APIC_VECTOR_MASK;
> }
>
> in addition to the above.
>
> -- Vitaly
Sounds good.
Paolo
