Re: [PATCH] KVM: apic: remove unused function apic_lvt_vector()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 2/12/20 6:37 PM, linmiaohe wrote:
From: Miaohe Lin <linmiaohe@xxxxxxxxxx>

The function apic_lvt_vector() is unused now, remove it.

Signed-off-by: Miaohe Lin <linmiaohe@xxxxxxxxxx>
---
  arch/x86/kvm/lapic.c | 5 -----
  1 file changed, 5 deletions(-)

diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c
index eafc631d305c..0b563c280784 100644
--- a/arch/x86/kvm/lapic.c
+++ b/arch/x86/kvm/lapic.c
@@ -294,11 +294,6 @@ static inline int apic_lvt_enabled(struct kvm_lapic *apic, int lvt_type)
  	return !(kvm_lapic_get_reg(apic, lvt_type) & APIC_LVT_MASKED);
  }
-static inline int apic_lvt_vector(struct kvm_lapic *apic, int lvt_type)
-{
-	return kvm_lapic_get_reg(apic, lvt_type) & APIC_VECTOR_MASK;
-}
-
  static inline int apic_lvtt_oneshot(struct kvm_lapic *apic)
  {
  	return apic->lapic_timer.timer_mode == APIC_LVT_TIMER_ONESHOT;

There is one place, lapic_timer_int_injected(), where this function be used :

        struct kvm_lapic *apic = vcpu->arch.apic;
-       u32 reg = kvm_lapic_get_reg(apic, APIC_LVTT);

        if (kvm_apic_hw_enabled(apic)) {

-                int vec = reg & APIC_VECTOR_MASK;

+               int vec = apic_lvt_vector(APIC_LVTT);
                 void *bitmap = apic->regs + APIC_ISR;


But since that's the only place I can find, we probably don't need a separate function.


Reviewed-by: Krish Sadhukhan <krish.sadhukhan@xxxxxxxxxx>




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux