Re: [PATCH] KVM: x86: eliminate some unreachable code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 2/12/20 6:53 PM, linmiaohe wrote:
From: Miaohe Lin <linmiaohe@xxxxxxxxxx>

These code are unreachable, remove them.

Signed-off-by: Miaohe Lin <linmiaohe@xxxxxxxxxx>
---
  arch/x86/kvm/vmx/vmx.c | 1 -
  arch/x86/kvm/x86.c     | 3 ---
  2 files changed, 4 deletions(-)

diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
index bb5c33440af8..b6d4eafe01cf 100644
--- a/arch/x86/kvm/vmx/vmx.c
+++ b/arch/x86/kvm/vmx/vmx.c
@@ -4505,7 +4505,6 @@ static bool rmode_exception(struct kvm_vcpu *vcpu, int vec)
  	case GP_VECTOR:
  	case MF_VECTOR:
  		return true;
-	break;
  	}
  	return false;
  }
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index fbabb2f06273..a597009aefd7 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -3081,7 +3081,6 @@ int kvm_get_msr_common(struct kvm_vcpu *vcpu, struct msr_data *msr_info)
  		break;
  	case APIC_BASE_MSR ... APIC_BASE_MSR + 0x3ff:
  		return kvm_x2apic_msr_read(vcpu, msr_info->index, &msr_info->data);
-		break;
  	case MSR_IA32_TSCDEADLINE:
  		msr_info->data = kvm_get_lapic_tscdeadline_msr(vcpu);
  		break;
@@ -3164,7 +3163,6 @@ int kvm_get_msr_common(struct kvm_vcpu *vcpu, struct msr_data *msr_info)
  		return kvm_hv_get_msr_common(vcpu,
  					     msr_info->index, &msr_info->data,
  					     msr_info->host_initiated);
-		break;
  	case MSR_IA32_BBL_CR_CTL3:
  		/* This legacy MSR exists but isn't fully documented in current
  		 * silicon.  It is however accessed by winxp in very narrow
@@ -8471,7 +8469,6 @@ static inline int vcpu_block(struct kvm *kvm, struct kvm_vcpu *vcpu)
  		break;
  	default:
  		return -EINTR;
-		break;
  	}
  	return 1;
  }
Reviewed-by: Krish Sadhukhan <krish.sadhukhan@xxxxxxxxxx>



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux