On 12/02/20 17:28, Sean Christopherson wrote: > On Wed, Feb 12, 2020 at 01:00:59PM +0100, Paolo Bonzini wrote: >> On 07/02/20 18:37, Sean Christopherson wrote: >>> Rename kvm_mmu->get_cr3() to call out that it is retrieving a guest >>> value, as opposed to kvm_mmu->set_cr3(), which sets a host value, and to >>> note that it will return L1's EPTP when nested EPT is in use. Hopefully >>> the new name will also make it more obvious that L1's nested_cr3 is >>> returned in SVM's nested NPT case. >>> >>> No functional change intended. >> >> Should we call it "get_pgd", since that is how Linux calls the top-level >> directory? I always get confused by PUD/PMD, but as long as we only >> keep one /p.d/ moniker it should be fine. > > Heh, I have the exact same sentiment. get_pgd() works for me. Ok, I'll post a patch that uses get_guest_pgd() as soon as I open kvm/next for 5.7 material. Paolo
