Re: [RFCv2 02/37] s390/protvirt: introduce host side setup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 04.02.20 10:28, Cornelia Huck wrote:
> On Mon, 3 Feb 2020 23:03:42 +0100
> Christian Borntraeger <borntraeger@xxxxxxxxxx> wrote:
> 
>> On 03.02.20 18:12, Cornelia Huck wrote:
>>> On Mon,  3 Feb 2020 08:19:22 -0500
>>> Christian Borntraeger <borntraeger@xxxxxxxxxx> wrote:
>>>   
>>>> From: Vasily Gorbik <gor@xxxxxxxxxxxxx>
>>>>
>>>> Introduce KVM_S390_PROTECTED_VIRTUALIZATION_HOST kbuild option for
>>>> protected virtual machines hosting support code.  
>>>
>>> Hm... I seem to remember that you wanted to drop this config option and
>>> always build the code, in order to reduce complexity. Have you
>>> reconsidered this?  
>>
>> I am still in favour of removing this, but I did not get an "yes, lets do
>> it" answer. Since removing is easier than re-adding its still in.
> 
> ok

Any preference from you?

[...]
> 
> I think I was confused about different things last time...
> 
> But that is probably a sign that this wants a comment :)

Will add

to kernel/uv.c
/* the bootdata_preserved fields come from ones in arch/s390/boot/uv.c */

to boot/uv.c
/* will be used in arch/s390/kernel/uv.c */


[...]
> Fair enough; it's just that it's not very clear from the messages in
> the log what happened. Maybe
> 
> "prot_virt: Running as protected virtualization guest."
> "prot_virt: The ultravisor call facility is not available."
> 
> That at least links back to the kernel parameter.

I will defer this until the end, in the hope to have a final name by then.




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux