Re: [PATCH 2/2] kvm: Add ioctl for gathering debug counters

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 1/23/20 5:15 PM, Paolo Bonzini wrote:
On 23/01/20 16:27, milanpa@xxxxxxxxxx wrote:

Paolo

I agree, extending the API with GET_AVAILABLE_ONE_REGS (and possibly a
bitmask argument to narrow down which type of registers userspace is
interested in) is a clean solution. We won't require userspace to rely
on constants in compile time if it doesn't need to.

Only concern is that now we need to have some kind of datastructure for
keeping the mappings between all available ONE_REG IDs and their
strings/descriptions. Additionally enforcing that newly added ONE_REGs
always get added to that mapping, is also necessary.
For now just do the implementation for VM ONE_REGs.  We'll worry about
the existing VCPU registers later.

Paolo

Sounds good.

Thanks for the help, I will update the patch soon.

Milan




Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879






[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux