On 1/23/20 4:05 PM, Paolo Bonzini wrote:
On 23/01/20 15:58, Alexander Graf wrote:
the case, of course it would be fine for me to use ONE_REG on a VM. The
part which I don't like is having to make all ONE_REG part of the
userspace ABI/API.
We don't have all of ONE_REG as part of the user space ABI today.
Still those that exist cannot change their id. This makes them a part
of the userspace ABI.
But I like the idea of a ONE_REG query interface that gives you the list
of available registers and a string representation of them. It would
make programming kvm from Python so easy!
Yeah, wouldn't it? Milan, what do you think about it?
Paolo
I agree, extending the API with GET_AVAILABLE_ONE_REGS (and possibly a
bitmask argument to narrow down which type of registers userspace is
interested in) is a clean solution. We won't require userspace to rely
on constants in compile time if it doesn't need to.
Only concern is that now we need to have some kind of datastructure for
keeping the mappings between all available ONE_REG IDs and their
strings/descriptions. Additionally enforcing that newly added ONE_REGs
always get added to that mapping, is also necessary.
Milan
Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879
