> On 10 Nov 2019, at 14:23, Liran Alon <liran.alon@xxxxxxxxxx> wrote: > > Because we are lucky and “latched_init" was last field in “struct smi” inside “struct kvm_vcpu_events”, > I will just move “latched_init” field outside of “struct smi” just before the “reserved” field. > Which would keep binary format compatibility while allowing making KVM code more clear. Forget about this. Because of padding this will cause to issues. And besides, it will break with any additional field added to “struct smi”. So I will keep field in “struct smi” even though it isn’t related specifically to SMM anymore… -Liran
