On 15/10/19 16:36, Vitaly Kuznetsov wrote: >> On 15/10/19 12:53, Vitaly Kuznetsov wrote: >>> A very theoretical question: why do we have 'struct vcpu' embedded in >>> vcpu_vmx/vcpu_svm and not the other way around (e.g. in a union)? That >>> would've allowed us to allocate memory in common code and then fill in >>> vendor-specific details in .create_vcpu(). >> Probably "because it's always been like that" is the most accurate answer. >> > OK, so let me make my question a bit less theoretical: would you be in > favor of changing the status quo? :-) Not really, it would be a lot of churn for debatable benefit. Paolo
