On 15/10/19 12:53, Vitaly Kuznetsov wrote: > A very theoretical question: why do we have 'struct vcpu' embedded in > vcpu_vmx/vcpu_svm and not the other way around (e.g. in a union)? That > would've allowed us to allocate memory in common code and then fill in > vendor-specific details in .create_vcpu(). Probably "because it's always been like that" is the most accurate answer. Paolo