On 08/10/19 17:06, Vitaly Kuznetsov wrote: > Jack Wang <jack.wang.usish@xxxxxxxxx> writes: > >> Vitaly Kuznetsov <vkuznets@xxxxxxxxxx> 于2019年10月8日周二 下午2:20写道: >>> >>> Nadav Amit <nadav.amit@xxxxxxxxx> writes: >>> >>>> Is kvm-unit-test supposed to pass on AMD machines or AMD VMs?. >>>> >>> >>> It is supposed to but it doesn't :-) Actually, not only kvm-unit-tests >>> but the whole SVM would appreciate some love ... >>> >>>> Clearly, I ask since they do not pass on AMD on bare-metal. >>> >>> On my AMD EPYC 7401P 24-Core Processor bare metal I get the following >>> failures: >>> >>> FAIL vmware_backdoors (11 tests, 8 unexpected failures) >>> >>> (Why can't we just check >>> /sys/module/kvm/parameters/enable_vmware_backdoor btw???) >>> >>> FAIL svm (15 tests, 1 unexpected failures) >>> >>> There is a patch for that: >>> >>> https://lore.kernel.org/kvm/d3eeb3b5-13d7-34d2-4ce0-fdd534f2bcc3@xxxxxxxxxx/T/#t >>> >> >>> Are you seeing different failures? >>> >>> -- >>> Vitaly >> On my test machine AMD Opteron(tm) Processor 6386 SE, bare metal: >> I got similar result: >> vmware_backdoors (11 tests, 8 unexpected failures) >> svm (13 tests, 1 unexpected failures), it failed on >> FAIL: tsc_adjust >> Latency VMRUN : max: 181451 min: 13150 avg: 13288 >> Latency VMEXIT: max: 270048 min: 13455 avg: 13623 > > Right you are, > > the failing test is also 'tsc_adjust' for me, npt_rsvd_pfwalk (which > Cathy fixed) is not being executed because we do '-cpu qemu64' for it. > > With the following: > > diff --git a/x86/unittests.cfg b/x86/unittests.cfg > index b4865ac..5ecb9bb 100644 > --- a/x86/unittests.cfg > +++ b/x86/unittests.cfg > @@ -198,7 +198,7 @@ arch = x86_64 > [svm] > file = svm.flat > smp = 2 > -extra_params = -cpu qemu64,+svm > +extra_params = -cpu host,+svm > arch = x86_64 > > [taskswitch] Patch please? :D Paolo > everything passes, including tsc_adjust: > > PASS: tsc_adjust > Latency VMRUN : max: 43240 min: 3720 avg: 3830 > Latency VMEXIT: max: 36300 min: 3540 avg: 3648 >