On 07/10/19 15:25, Liang, Kan wrote: > >> On 30/09/19 09:22, Like Xu wrote: >>> -static int perf_event_period(struct perf_event *event, u64 __user *arg) >>> +static int _perf_event_period(struct perf_event *event, u64 value) >> >> __perf_event_period or perf_event_period_locked would be more consistent >> with other code in Linux. >> > > But that will be not consistent with current perf code. For example, > _perf_event_enable(), _perf_event_disable(), _perf_event_reset() and > _perf_event_refresh(). > Currently, The function name without '_' prefix is the one exported and > with lock. The function name with '_' prefix is the main body. > > If we have to use the "_locked" or "__", I think we'd better change the > name for other functions as well. Oh, sorry I missed that. Paolo
