> On 30 Sep 2019, at 20:20, Sean Christopherson <sean.j.christopherson@xxxxxxxxx> wrote:
>
> On Mon, Sep 30, 2019 at 09:35:59AM -0700, Jim Mattson wrote:
>> On Mon, Sep 30, 2019 at 12:34 AM Vitaly Kuznetsov <vkuznets@xxxxxxxxxx> wrote:
>>>
>>> Liran Alon <liran.alon@xxxxxxxxxx> writes:
>>>
>>>> Commit bf653b78f960 ("KVM: vmx: Introduce handle_unexpected_vmexit
>>>> and handle WAITPKG vmexit") introduced proprietary handling of
>>>> specific exit-reasons that should not be raised by CPU because
>>>> KVM configures VMCS such that they should never be raised.
>>>>
>>>> However, since commit 7396d337cfad ("KVM: x86: Return to userspace
>>>> with internal error on unexpected exit reason"), VMX & SVM
>>>> exit handlers were modified to generically handle all unexpected
>>>> exit-reasons by returning to userspace with internal error.
>>>>
>>>> Therefore, there is no need for proprietary handling of specific
>>>> unexpected exit-reasons (This proprietary handling also introduced
>>>> inconsistency for these exit-reasons to silently skip guest instruction
>>>> instead of return to userspace on internal-error).
>>>>
>>>> Fixes: bf653b78f960 ("KVM: vmx: Introduce handle_unexpected_vmexit and handle WAITPKG vmexit")
>>>>
>>>> Signed-off-by: Liran Alon <liran.alon@xxxxxxxxxx>
>>>
>>> (It's been awhile since in software world the word 'proprietary' became
>>> an opposite of free/open-source to me so I have to admit your subject
>>> line really got me interested :-)
>>>
>>> Reviewed-by: Vitaly Kuznetsov <vkuznets@xxxxxxxxxx>
>>
>> I agree that proprietary is an unusual word choice.
>
> It's one way to get quick reviews though :-)
OK Ok I apologise for my bad English. ^_^
Paolo, feel free to reword this commit title & message to something else when applying…
-Liran
