On 05/09/2019 12.39, Janosch Frank wrote:
> With SMP we also get new external interrupts like external call and
> emergency call. Let's make them known.
>
> Signed-off-by: Janosch Frank <frankja@xxxxxxxxxxxxx>
> ---
[...]
> @@ -108,15 +116,23 @@ void handle_pgm_int(void)
>
> void handle_ext_int(void)
> {
> - if (lc->ext_int_code != EXT_IRQ_SERVICE_SIG) {
> + if (!ext_int_expected &&
> + lc->ext_int_code != EXT_IRQ_SERVICE_SIG) {
> report_abort("Unexpected external call interrupt: at %#lx",
> lc->ext_old_psw.addr);
> - } else {
> - lc->ext_old_psw.mask &= ~PSW_MASK_EXT;
> + return;
> + }
> +
> + if (lc->ext_int_code == EXT_IRQ_SERVICE_SIG) {
> lc->sw_int_cr0 &= ~(1UL << 9);
> sclp_handle_ext();
> - lc->ext_int_code = 0;
> }
> + if (lc->ext_int_code != EXT_IRQ_SERVICE_SIG) {
I think you could simplify above line to "else {" ?
With that change:
Reviewed-by: Thomas Huth <thuth@xxxxxxxxxx>
