On Tue, Jul 30, 2019 at 5:40 PM Paolo Bonzini <pbonzini@xxxxxxxxxx> wrote: > > On 30/07/19 14:08, Anup Patel wrote: > >> Still, I would prefer all the VS CSRs to be accessible via the get/set > >> reg ioctls. > > We had implemented VS CSRs access to user-space but then we > > removed it to keep this series simple and easy to review. We thought > > of adding it later when we deal with Guest/VM migration. > > > > Do you want it to be added as part of this series ? > > Yes, please. It's not enough code to deserve a separate patch, and it > is useful for debugging. Sure, I will add it in v2 series. We have skipped Guest FP ONE_REG interface with same rationale. We should add that as well. Agree ? Regards, Anup
