On 7/16/19 11:10 AM, Sean Christopherson wrote: > On Tue, Jul 16, 2019 at 07:01:30PM +0300, Liran Alon wrote: >> >>> On 16 Jul 2019, at 18:48, Sean Christopherson <sean.j.christopherson@xxxxxxxxx> wrote: >>> kvm_make_request(KVM_REQ_TRIPLE_FAULT, vcpu); >>> return false; >> >> I don’t think we should triple-fault and return “false”. As from a semantic >> perspective, we should return true. > > Fair enough, I guess it's no different than the warn-and-continue logic > used in the unreachable VM-Exit handlers. > >> But this commit is getting really philosophical :) Maybe let’s hear Paolo’s >> preference first before doing any change. > > Hence my recommendation to put the function change in a separate patch :-) > Well, during the initial patch we had some discussion about the function names. At that time we all felt the name was okay. I don't have any strong preference. Lets go with whatever everyone agrees to :) -Brijesh
