On Tue, Jul 16, 2019 at 07:01:30PM +0300, Liran Alon wrote: > > > On 16 Jul 2019, at 18:48, Sean Christopherson <sean.j.christopherson@xxxxxxxxx> wrote: > > kvm_make_request(KVM_REQ_TRIPLE_FAULT, vcpu); > > return false; > > I don’t think we should triple-fault and return “false”. As from a semantic > perspective, we should return true. Fair enough, I guess it's no different than the warn-and-continue logic used in the unreachable VM-Exit handlers. > But this commit is getting really philosophical :) Maybe let’s hear Paolo’s > preference first before doing any change. Hence my recommendation to put the function change in a separate patch :-)