On 10.07.19 19:06, Paolo Bonzini wrote:
On 10/07/19 19:02, Andre Przywara wrote:
+ * This test verifies whether the emulated PL031 behaves
correctly.
^^^^^^^^
While I appreciate the effort and like the fact that this actually
triggers an SPI, I wonder if this actually belongs into
kvm-unit-tests. After all this just test a device purely emulated in
(QEMU) userland, so it's not really KVM related.
What is the general opinion on this? Don't we care about this
hair-splitting as long as it helps testing? Do we even want to extend
kvm-unit-tests coverage to more emulated devices, for instance
virtio?
I agree that it would belong more in qtest, but tests in not exactly the
right place is better than no tests.
The problem with qtest is that it tests QEMU device models from a QEMU
internal view.
I am much more interested in the guest visible side of things. If
kvmtool wanted to implement a PL031, it should be able to execute the
same test that we run against QEMU, no?
If kvm-unit-test is the wrong place for it, we would probably want to
have a separate testing framework for guest side unit tests targeting
emulated devices.
Given how nice the kvm-unit-test framework is though, I'd rather rename
it to "virt-unit-test" than reinvent the wheel :).
Alex
