Re: [PATCH kvm-unit-tests] arm: Add PL031 test

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/07/19 19:02, Andre Przywara wrote:
>> + * This test verifies whether the emulated PL031 behaves
>> correctly.
> ^^^^^^^^
> 
> While I appreciate the effort and like the fact that this actually
> triggers an SPI, I wonder if this actually belongs into
> kvm-unit-tests. After all this just test a device purely emulated in
> (QEMU) userland, so it's not really KVM related.
> 
> What is the general opinion on this? Don't we care about this
> hair-splitting as long as it helps testing? Do we even want to extend
> kvm-unit-tests coverage to more emulated devices, for instance
> virtio?

I agree that it would belong more in qtest, but tests in not exactly the
right place is better than no tests.

Paolo



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux