Michael S. Tsirkin wrote: > On Tue, Jul 07, 2009 at 01:26:11PM -0400, Gregory Haskins wrote: > > >> I suppose its personal preference either way, so I guess unless Avi >> objects lets just each have our own style in that regard. >> > > I think Avi already said we don't need to standardize everything. > I hope at least some of the comments were helpful. > > Yes, it was very helpful and I really *do* appreciate the time you take to review the code. I think you will see that aside from the things we agree are whitespace style, I addressed your feedback in v10. The one notable omission (and this was not intentional) was that I forgot to document the return value like you requested. If a v11 is needed after review comments, I will update it then. Otherwise, Ill just submit a trivial doc patch after v10 is accepted. Thanks again, Michael, -Greg
Attachment:
signature.asc
Description: OpenPGP digital signature
