> On Jun 6, 2019, at 5:26 AM, Paolo Bonzini <pbonzini@xxxxxxxxxx> wrote:
>
> On 20/05/19 11:55, Nadav Amit wrote:
>> The test succeeds in failing entry. This is not an expected failure.
>>
>> Cc: Marc Orr <marcorr@xxxxxxxxxx>
>> Signed-off-by: Nadav Amit <nadav.amit@xxxxxxxxx>
>> ---
>> x86/vmx.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/x86/vmx.c b/x86/vmx.c
>> index f540e15..014bf50 100644
>> --- a/x86/vmx.c
>> +++ b/x86/vmx.c
>> @@ -1833,8 +1833,7 @@ void enter_guest_with_bad_controls(void)
>> "Called enter_guest() after guest returned.");
>>
>> ok = vmx_enter_guest(&failure);
>> - report_xfail("vmlaunch fails, as expected",
>> - true, ok);
>> + report("vmlaunch fails, as expected", !ok);
>> report("failure occurred early", failure.early);
>> report("FLAGS set correctly",
>> (failure.flags & VMX_ENTRY_FLAGS) == X86_EFLAGS_ZF);
>
> Superseded by commit 74f7e9b ("vmx: introduce
> enter_guest_with_invalid_guest_state", 2019-04-18); thanks anyway!
I have some related fixes for recent commits, so I will be waiting for you
to push the updated kvm-unit-tests before I send the next batch of fixes.
