Re: [PATCHv4 4/5] qemu/msi: missing braces

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/05/2009 02:56 PM, Michael S. Tsirkin wrote:
With the braces comment I meant that while working on the code, you
should update it to match CODING_STYLE:
if (!(dev->cap_present&  QEMU_PCI_CAP_MSIX)) {
     return;
}

Yea ... it's probably better to do this all over the file, not piecewise,
though. No?

No, that just causes churn (and merge conflicts for me). Better to only fix if you have a patch that modifies the same place.

--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux