On Sun, Jul 05, 2009 at 02:48:12PM +0300, Blue Swirl wrote:
> On 7/5/09, Michael S. Tsirkin <mst@xxxxxxxxxx> wrote:
> > MSIX present bit is tested incorrectly, and only happens to work because
> > the bit we are testing is 0x1. Add braces to fix this.
> >
> > Reported-by: Blue Swirl <blauwirbel@xxxxxxxxx>
> > Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx>
> > ---
> > hw/msix.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/hw/msix.c b/hw/msix.c
> > index 33549f5..db72cc3 100644
> > --- a/hw/msix.c
> > +++ b/hw/msix.c
> > @@ -298,7 +298,7 @@ void msix_load(PCIDevice *dev, QEMUFile *f)
> > {
> > unsigned n = dev->msix_entries_nr;
> >
> > - if (!dev->cap_present & QEMU_PCI_CAP_MSIX)
> > + if (!(dev->cap_present & QEMU_PCI_CAP_MSIX))
>
> With the braces comment I meant that while working on the code, you
> should update it to match CODING_STYLE:
> if (!(dev->cap_present & QEMU_PCI_CAP_MSIX)) {
> return;
> }
Yea ... it's probably better to do this all over the file, not piecewise,
though. No?
--
MST
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
